Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nodejs): propose working directory #3

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat(nodejs): propose working directory #3

wants to merge 11 commits into from

Conversation

jplanckeel
Copy link

we want use this action on monorepo with subfolder

@jplanckeel
feat(nodejs): propose working directory
b56f4aa 
we want use this action on monorepo with subfolder
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jplanckeel
❌ Jeremy PLANCKEEL

Jeremy PLANCKEEL seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

ArthurKnoep
ArthurKnoep requested changes Jan 15, 2022
View reviewed changes
Copy link
Member

@ArthurKnoep ArthurKnoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for your contribution and sorry for the delay I had a pretty busy week

Your PR seems fine, just few things to fix before I can accept it.

Also you'll need to sign the CLA, I know it's a pain but as we are a company we need to back up ourselves (rest assured that we will most likely never earn any money with this project 😆)

action.yml Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
ArthurKnoep
ArthurKnoep approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@ArthurKnoep ArthurKnoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@jplanckeel
Copy link
Author

Hi @ArthurKnoep can you merge this PR ?

@ArthurKnoep
Copy link
Member

It seems that you haven't signed the contributor license agreement, you can sign it there: https://cla-assistant.io/ReyahSolutions/matrix-git-generator?pullRequest=3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurKnoep ArthurKnoep ArthurKnoep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplanckeel @CLAassistant @ArthurKnoep